/
Code review - 3/31/2020

Code review - 3/31/2020

Owned by Swetha Kiledar Siddaramappa (Deactivated)
Last updated: Apr 01, 2020
2 min read

  • CRX.API - Change the response that is coming from the API to not send back and the datatable directly from SP

  • Structure is not standardized as Welnity’s code is in the API.Generic project

  • RestClientFactory.CreateClient is the same as new RestClient (getting from util.getconfigvalue(“URLBase”))

  • Clean up RestClientFactory and remove the case for PCIC

    • Update HomeController to get new RestClient for Welnity

  • in HomeController → the if/else is excessive

  • Exception handling for Welnity in WelnityRequest.cs is not the same as PCIC’s API endpoint calling

  • Clean-up the API project to be 1 standard mechanism

    • Exception handling

    • Response return

  • Well-structured design is required

  • No value add of RestClientFactory

  • Valli - Systems architecture for API structure and flow

    • API model diagram for design of it

    • If requests are going to eReferral then it is straight going into API

    • Resources will go to generic

  • What happens when connectivty should happen between 2 referral systems

  • 1 standard way of coding

    • coming to generic’s homecontroller

      • Is routed to the endpoint

      • one std for error handling

    • Translation layer for returning the response from SP

  • On the CCC

    • The 2 files for CRX and Welnity API should not exist

      • This is the responsibility of the CRX API to handle all of this translation

  • STEP 1 - Where is the design?

    • Here’s my generic list of output that comes back to the app

      • How many of these data points map to PCIC vs Welnity

  • No code on CCC should be specific to a resource provider endpoint

  • 1 single respinse object

    • Figure out the response object by seeing the output from both PCIC and Welnity

      • List of output data from

  • What is nullable vs not nullable

    • Output needs to generate the transaltion

    • get the output straight into the generic object

    • Put it in excel → attributes returning from Welnity vs PCIC

  • Code - It should be clean to understand

  • Specific questions - Call Kallol immediately

  • Concerned on performance of looping through 1 object to another

    • Valli - Getting an entire datatable and iterating to push to a data class

    • Puneeth - Response results in foreach loops

      • Performance is inefficient for large rows of data

  • eReferals going directly to api/v1 instead of going to generic

    • Review the diagram for CRX. Reuse the exact same structure as resources. Connecting CCC to CombinedArms. (they don’t separate resource and referrals)

    • If a request is coming from CCC to go to CombinedArms, you can go to CRX

      • We don’t know how much attributes are overlapping for sending an eReferral

      • It can still be decided at the CRX

 

4/1

  • Send “specialty” as JSON and not a , delimited string

    • Deploy as is for the current production build

    • Make these updates as part of the next iteration

  • Have overloads for the response returned

  • We need separate endpoints to bring back a list of eReferrals with grouping value

    • Such end-points don’t need the complete payload of eReferral details

  • For resourceresponse object (CRXResourceResponseObj)

    • Move all concatenated strings to a list

  • Puneeth will update and send it across